Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Maze::positionConsideringTunnel() #100

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Fix Maze::positionConsideringTunnel() #100

merged 2 commits into from
Dec 19, 2024

Conversation

orzechow
Copy link
Member

@orzechow orzechow commented Dec 6, 2024 •
edited
Loading

This fixes the Demo crashing at tunnels: #90

The Maze::positionConsideringTunnel() now always returns a valid maze position, by either wrapping or clamping (tunnel or wall).

#patch

@orzechow orzechow linked an issue Dec 6, 2024 that may be closed by this pull request
Demo crashes when entering the tunnel #90
Closed
@orzechow
Copy link
Member Author

orzechow commented Dec 6, 2024

@ll-nick :)

ll-nick
ll-nick approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@ll-nick ll-nick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one!

@orzechow orzechow merged commit c5a6894 into main Dec 19, 2024
1 check passed
@orzechow orzechow deleted the fix_position_considering_tunnel branch December 19, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ll-nick ll-nick ll-nick approved these changes

@ChristophBurger89 ChristophBurger89 Awaiting requested review from ChristophBurger89 ChristophBurger89 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demo crashes when entering the tunnel
2 participants
@orzechow @ll-nick